London | 6-SDC-Aug | Boshra Mahmoudi | Sprint 3 | Implement shell tools - #652
Open
BoshraM wants to merge 17 commits into
Open
Conversation
added 17 commits
July 28, 2026 02:16
BoshraM
added
📅 Sprint 3
LonMcGregor
reviewed
Aug 12, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start, but I think there are some changes that could be made
| import { readFile } from "node:fs/promises"; | ||
| import process from "node:process"; | ||
|
|
||
| const argv = process.argv.slice(2); |
Contributor
There was a problem hiding this comment.
Is there a library or API you could use to handle arguments for you?
| } | ||
|
|
||
| if (files.length > 1 ) { | ||
| if (countLines && countWords) { |
Contributor
There was a problem hiding this comment.
There's some repeated patterns of code here, can you find a way to reduce it?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is related to the Shell pipelines exercise task in the CYF Circulum sprint2.
Task ID: CYF-1150